feat(addon-doc): add aria-label for dark mode button #9108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splincode
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin,
nsbarsukov and
mdlufy
as code owners
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
|
Visit the preview URL for this PR (updated for commit a3a7231): https://taiga-previews--pr9108-splincode-demo-1-5pnbby5i.web.app (expires Fri, 20 Sep 2024 19:45:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a |
BundleMonFiles updated (1)
Unchanged files (4)
Total files change +26B 0% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
splincode
changed the title
waterplea
approved these changes
Sep 23, 2024
| @@ -11,6 +11,7 @@ | |||
| <ng-content select="tuiDocHeader" /> | |||
| <button | |||
| appearance="secondary" | |||
| aria-label="Switch between dark and light mode" | |||
There was a problem hiding this comment.
You can just write this directly inside the button, that's exactly what we have font-size: 0 in icon buttons
There was a problem hiding this comment.
What do you mean about directly?
nsbarsukov
approved these changes
Sep 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After